Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 10767 invoked from network); 4 Mar 2009 21:44:21 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Mar 2009 21:44:21 -0000 Received: (qmail 79778 invoked by uid 500); 4 Mar 2009 21:44:17 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 79587 invoked by uid 500); 4 Mar 2009 21:44:17 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 79576 invoked by uid 99); 4 Mar 2009 21:44:17 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Mar 2009 13:44:17 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Mar 2009 21:44:16 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 4D81C234C4AF for ; Wed, 4 Mar 2009 13:43:56 -0800 (PST) Message-ID: <543524362.1236203036316.JavaMail.jira@brutus> Date: Wed, 4 Mar 2009 13:43:56 -0800 (PST) From: "Tsz Wo (Nicholas), SZE (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-5384) DataNodeCluster should not create blocks with generationStamp == 1 In-Reply-To: <886697565.1236127856072.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-5384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678940#action_12678940 ] Tsz Wo (Nicholas), SZE commented on HADOOP-5384: ------------------------------------------------ Yes, it is good to add a new Block constructor. I think we better to refactor the constructors of Block so that the invalid values can be detected. How about we do it in a separated JIRA? > DataNodeCluster should not create blocks with generationStamp == 1 > ------------------------------------------------------------------ > > Key: HADOOP-5384 > URL: https://issues.apache.org/jira/browse/HADOOP-5384 > Project: Hadoop Core > Issue Type: Bug > Components: test > Reporter: Tsz Wo (Nicholas), SZE > Attachments: 5384_20090303.patch > > > In DataNodeCluster.main(..), injected blocks are created with generationStamp == 1, which is a reserved value but not a valid generation stamp. As a consequence, NameNode may die when those blocks are reported. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.