Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 31990 invoked from network); 17 Mar 2009 12:59:26 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 17 Mar 2009 12:59:26 -0000 Received: (qmail 20515 invoked by uid 500); 17 Mar 2009 12:59:14 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 20427 invoked by uid 500); 17 Mar 2009 12:59:14 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 20394 invoked by uid 99); 17 Mar 2009 12:59:13 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Mar 2009 05:59:13 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Mar 2009 12:59:11 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 79B76234C003 for ; Tue, 17 Mar 2009 05:58:50 -0700 (PDT) Message-ID: <248454325.1237294730490.JavaMail.jira@brutus> Date: Tue, 17 Mar 2009 05:58:50 -0700 (PDT) From: "Hemanth Yamijala (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-5516) TaskMemoryManagerThread crashes in a corner case In-Reply-To: <1523767841.1237280090549.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682666#action_12682666 ] Hemanth Yamijala commented on HADOOP-5516: ------------------------------------------ Regarding changes in trunk, some minor nits: - TaskMemoryManagerThread, there is an indentation problem in one of the comments, which is becoming very misleading. Search for "updated state" - Same method, the call to pTree.destroy(); was pTree.destroy(true); in trunk. Though this is the default value for the overloaded API, I think it is better to retain the original code in case it changes in future. > TaskMemoryManagerThread crashes in a corner case > ------------------------------------------------ > > Key: HADOOP-5516 > URL: https://issues.apache.org/jira/browse/HADOOP-5516 > Project: Hadoop Core > Issue Type: Bug > Components: mapred > Affects Versions: 0.20.0 > Reporter: Vinod K V > Assignee: Vinod K V > Priority: Blocker > Fix For: 0.20.0 > > Attachments: HADOOP-5516-1.txt, HADOOP-5516-trunk-1.txt > > > TT's stdout says. > {code} > Exception in thread "org.apache.hadoop.mapred.TaskMemoryManagerThread" java.lang.NullPointerException > at org.apache.hadoop.util.ProcfsBasedProcessTree.getProcessTree(ProcfsBasedProcessTree.java:126) > at org.apache.hadoop.mapred.TaskMemoryManagerThread.run(TaskMemoryManagerThread.java:200) > {code} > TaskMemoryManager crashes and no further memory management is done. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.