Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 29522 invoked from network); 27 Mar 2009 01:15:12 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 27 Mar 2009 01:15:12 -0000 Received: (qmail 35814 invoked by uid 500); 27 Mar 2009 01:15:11 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 35750 invoked by uid 500); 27 Mar 2009 01:15:11 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 35738 invoked by uid 99); 27 Mar 2009 01:15:11 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Mar 2009 01:15:11 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Mar 2009 01:15:10 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 6D58B234C003 for ; Thu, 26 Mar 2009 18:14:50 -0700 (PDT) Message-ID: <229027457.1238116490433.JavaMail.jira@brutus> Date: Thu, 26 Mar 2009 18:14:50 -0700 (PDT) From: "Hadoop QA (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-4045) Increment checkpoint if we see failures in rollEdits In-Reply-To: <153989470.1219992524637.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-4045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689773#action_12689773 ] Hadoop QA commented on HADOOP-4045: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12403739/HADOOP-4045-1.patch against trunk revision 758593. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/144/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/144/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/144/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/144/console This message is automatically generated. > Increment checkpoint if we see failures in rollEdits > ---------------------------------------------------- > > Key: HADOOP-4045 > URL: https://issues.apache.org/jira/browse/HADOOP-4045 > Project: Hadoop Core > Issue Type: Bug > Components: dfs > Reporter: Lohit Vijayarenu > Assignee: Boris Shkolnik > Priority: Critical > Fix For: 0.19.2 > > Attachments: HADOOP-4045-1.patch, HADOOP-4045.patch > > > In _FSEditLog::rollEdits_, if we encounter an error during opening edits.new, we remove the store directory associated with it. At this point we should also increment checkpoint on all other directories. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.