Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <1508656195.1236616250495.JavaMail.jira@brutus>
Date: Mon, 9 Mar 2009 09:30:50 -0700 (PDT)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-5411) Use StringBuffer for building
 Chukwa Chart object
In-Reply-To: <2024220372.1236281036091.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680190#action_12680190 ] 

Hadoop QA commented on HADOOP-5411:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12401580/HADOOP-5411.patch
  against trunk revision 751463.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/35/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/35/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/35/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/35/console

This message is automatically generated.

> Use StringBuffer for building Chukwa Chart object
> -------------------------------------------------
>
>                 Key: HADOOP-5411
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5411
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/chukwa
>         Environment: Redhat 5.1, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Minor
>         Attachments: HADOOP-5411.patch
>
>
> The Chukwa Chart object is using String to build the ajax chart data.  This should be converted to use StringBuffer to speed up efficiency.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.