Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <1105202221.1238102090641.JavaMail.jira@brutus>
Date: Thu, 26 Mar 2009 14:14:50 -0700 (PDT)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-5571) TupleWritable can return incorrect
 results if it contains more than 32 values
In-Reply-To: <509819842.1237985812108.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689666#action_12689666 ] 

Hadoop QA commented on HADOOP-5571:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12403606/HADOOP-5571-1.patch
  against trunk revision 758593.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/142/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/142/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/142/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/142/console

This message is automatically generated.

> TupleWritable can return incorrect results if it contains more than 32 values
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-5571
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5571
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.19.1
>            Reporter: Jingkei Ly
>            Assignee: Jingkei Ly
>         Attachments: HADOOP-5571-1.patch
>
>
> When attempting to do an outer join on 45 files with the CompositeInputFormat, I've been encountering unexpected results in the TupleWritable returned by the record reader. On closer inspection, it seems to be because TupleWritable.setWritten(int) is incorrectly setting some tuple positions as written, i.e when you set setWritten(42), it also sets position 10.
> The following Junit test demonstrates the problem:
> {code}
>   public void testWideTuple() throws Exception {
>     Text emptyText = new Text("Should be empty");
>     Writable[] values = new Writable[64];
>     Arrays.fill(values,emptyText);
>     values[42] = new Text("Number 42");
>                                      
>     TupleWritable tuple = new TupleWritable(values);
>     tuple.setWritten(42);
>     
>     for (int pos=0; pos<tuple.size();pos++) {
>       boolean has = tuple.has(pos);
>       if (pos == 42) {
>         assertTrue(has);
>       }
>       else {
>         assertFalse("Tuple position is incorrectly labelled as set: " + pos, has);
>       }
>     }
> }
> {code}
> Similarly, TupleWritable.setWritten(9) also causes TupleWritable.has(41) to incorrectly return true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.