Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 66639 invoked from network); 23 Mar 2009 19:08:12 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 23 Mar 2009 19:08:12 -0000 Received: (qmail 98657 invoked by uid 500); 23 Mar 2009 19:08:11 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 98609 invoked by uid 500); 23 Mar 2009 19:08:11 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 98599 invoked by uid 99); 23 Mar 2009 19:08:11 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Mar 2009 19:08:11 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Mar 2009 19:08:10 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 729A2234C003 for ; Mon, 23 Mar 2009 12:07:50 -0700 (PDT) Message-ID: <1036361260.1237835270454.JavaMail.jira@brutus> Date: Mon, 23 Mar 2009 12:07:50 -0700 (PDT) From: "Konstantin Shvachko (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-5551) Namenode permits directory destruction on overwrite In-Reply-To: <1381222840.1237740470810.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-5551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688383#action_12688383 ] Konstantin Shvachko commented on HADOOP-5551: --------------------------------------------- Looks like your solution will work only if permission is enabled. If not it will still replace the directory by the file. Could you please include a test for that. You can just add a test case to TestFileCreation in order to avoid cluster startup / shutdown just for this one operation. > Namenode permits directory destruction on overwrite > --------------------------------------------------- > > Key: HADOOP-5551 > URL: https://issues.apache.org/jira/browse/HADOOP-5551 > Project: Hadoop Core > Issue Type: Bug > Affects Versions: 0.19.1 > Reporter: Brian Bockelman > Priority: Critical > Attachments: HADOOP-5551.patch > > > The FSNamesystem's startFileInternal allows overwriting of directories. That is, if you have a directory named /foo/bar and you try to write a file named /foo/bar, the file is written and the directory disappears. > This is most apparent for folks using libhdfs directly, as overwriting is always turned on. Therefore, if libhdfs applications do not check the existence of a directory first, then they will permit new files to destroy directories. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.