hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "zhiyong zhang (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-5386) To Probe free ports dynamically for Unit test to replace fixed ports
Date Thu, 05 Mar 2009 07:49:56 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

zhiyong zhang updated HADOOP-5386:
----------------------------------

    Attachment: HADOOP-5386.patch

    *  As part of this patch, would it be possible to cut the test timeout from 3 minutes
to 30 seconds at most?  
Yes done
    * Ideally, the proxy would start up on a random port instead of writing the config from
ant, but OK. Since FindFreePort is used only in the unit tests, it should probably:
          o Move under hdfsproxy/test/...
Yes done.
          o Write the whole config file instead of using sed in a later ant task
I changed to use ant copy plus token filter. should be more elegant than sed.
          o Pick a random port instead of starting at a fixed port and rolling to find an
open one
Yes. I changed FindFreePort to select a random port to start with
    * ant -Dtestcase=TestHdfsProxy test fails reliably on my machine:
Fixed, don't rely on HADOOP_CONF_DIR environment. should work fine now.

    * Note that hdfsproxy isn't the last project in test, but the failure stops the build.
That should be fixed, either as part of this issue or in another one.
I explored quite a few time on that. Unfortunately I don't think ant can continue run build
if some part fails. Unless we want to return success even if it fails. It would be nice if
ant is like gcc compiler, returning all the errors or failures after the full build. But ant
can't do that (i think). If it is proven otherwise, please let me know. 
    * When ant -Dtestcase=FOO test is run, this still starts tomcat.
Fixed. 



> To Probe free ports dynamically for Unit test to replace fixed ports
> --------------------------------------------------------------------
>
>                 Key: HADOOP-5386
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5386
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/hdfsproxy
>    Affects Versions: 0.21.0
>            Reporter: zhiyong zhang
>            Assignee: zhiyong zhang
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5386.patch, HADOOP-5386.patch
>
>
> Currently hdfsproxy unit test uses Cactus in-container test. It uses three fixed ports.
one for tomcat start-up/shut-down, another for tomcat http-port and the third for tomcat https-port.

> If theses ports are already in use, ant build will fail. To fix this, we decided to use
a java program to probe the free ports dynamically and update the tomcat conf with these free
ports. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message