hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5481) Namenode should return lease recovery request with other requests
Date Fri, 13 Mar 2009 02:52:50 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681586#action_12681586

Hadoop QA commented on HADOOP-5481:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 753052.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/57/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/57/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/57/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/57/console

This message is automatically generated.

> Namenode should return lease recovery request with other requests
> -----------------------------------------------------------------
>                 Key: HADOOP-5481
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5481
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: HADOOP-5481.patch
> HADOOP-5034 modified NN to return both replication and deletion requests to DN in one
reply to a heartbeat. However, the lease recovery request is still sent separately by itself.
Is there a reason for this? If not, I suggest we combine them together. This will make it
less confusing when adding new types of requests, which are combinable as well.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message