hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5449) Verify if JobHistory.HistoryCleaner works as expected
Date Fri, 13 Mar 2009 15:05:55 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681770#action_12681770
] 

Hudson commented on HADOOP-5449:
--------------------------------

Integrated in Hadoop-trunk #778 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/778/])
    . Fixes the history cleaner thread. Contributed by Amareshwari Sriramadasu.
. Fixes the history cleaner thread. Contributed by Amareshwari Sriramadasu.


> Verify if JobHistory.HistoryCleaner works as expected
> -----------------------------------------------------
>
>                 Key: HADOOP-5449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5449
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Amar Kamat
>            Assignee: Amareshwari Sriramadasu
>            Priority: Blocker
>             Fix For: 0.19.2
>
>         Attachments: patch-5449.txt
>
>
> Here is the piece of code I doubt
> {code}
> public void run(){
>       if (isRunning){
>         return;
>       }
>       now = System.currentTimeMillis();
>       // clean history only once a day at max
>       if (lastRan ==0 || (now - lastRan) < ONE_DAY_IN_MS){
>         return;
>       }
>       lastRan = now;
> .....
> // main code for cleaning
> }
> {code}
> {{lastRun}} is initialized to 0 and hence HistoryCleaner will never execute the main
code. Also a testcase should be written for JobHistory.HistoryCleaner to check if it works
as expected. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message