hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] Reopened: (HADOOP-5307) Fix null value handling in StringUtils#arrayToString() and #getStrings()
Date Wed, 11 Mar 2009 17:30:50 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-5307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Douglas reopened HADOOP-5307:
-----------------------------------


I reverted this for two procedural reasons:
# The patch never received a +1 or review
# Committing it all the way back to 0.19 is arguably appropriate, particularly since it's
an incompatible change

As for the content of the patch, adding a special value parsed as "null" without escaping
literal instances of it in a utility class is not good. The use case is also unclear; where
is this causing problems, configuration or otherwise?

> Fix null value handling in StringUtils#arrayToString() and #getStrings()
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-5307
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5307
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.21.0
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>         Attachments: h5307_v1.patch
>
>
> StringUtils#arrayToString() converts String array to a String of comma separated elements.
If the String array includes null values, these are recovered as "null" (literal) from getStrings()
method, which eventually causes configuration issues. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message