hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hong Tang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4655) FileSystem.CACHE should be ref-counted
Date Mon, 09 Mar 2009 20:35:50 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680261#action_12680261
] 

Hong Tang commented on HADOOP-4655:
-----------------------------------

Read through the java part of the patch, looks mostly good to me. Two questions:
- What should be the semantics of FileSystem.equals()? Should two unique instances pointing
to the same File System be considered equal or not?
- There seems to be a redundant line of import of atomic.AtomicLong



> FileSystem.CACHE should be ref-counted
> --------------------------------------
>
>                 Key: HADOOP-4655
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4655
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs, fs
>    Affects Versions: 0.18.1, 0.18.2, 0.19.0, 0.19.1, 0.20.0
>            Reporter: Hong Tang
>            Assignee: dhruba borthakur
>             Fix For: 0.20.0
>
>         Attachments: FileSystemUnique.patch, FileSystemUnique.txt
>
>
> FileSystem.CACHE is not ref-counted, and could lead to resource leakage.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message