hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5236) Unreachable code in TaskInProgress.inCompleteSubTask
Date Tue, 10 Mar 2009 06:20:50 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680389#action_12680389
] 

Hadoop QA commented on HADOOP-5236:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12400933/patch-5236.txt
  against trunk revision 751870.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/40/console

This message is automatically generated.

> Unreachable code in TaskInProgress.inCompleteSubTask
> ----------------------------------------------------
>
>                 Key: HADOOP-5236
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5236
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: patch-5236.txt
>
>
> TaskInProgress.incompleteSubTask has the following unreachable-code :
> {noformat}
>     if (taskState != TaskStatus.State.FAILED && 
>           taskState != TaskStatus.State.KILLED &&
>           taskState != TaskStatus.State.FAILED_UNCLEAN &&
>           taskState != TaskStatus.State.KILLED_UNCLEAN) {
>         LOG.info("Task '" + taskid + "' running on '" + trackerName + 
>                 "' in state: '" + taskState + "' being failed!");
>         status.setRunState(TaskStatus.State.FAILED);
>         taskState = TaskStatus.State.FAILED;
>       }
> {noformat}
> It would never reach this code, because it is never called from other places, where taskState
is not FAILED, KILLED, FAILED_UNCLEAN and KILLED_UNCLEAN.
> Also status != null is not required, since status is never null.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message