hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5386) To Probe free ports dynamically for Unit test to replace fixed ports
Date Sat, 07 Mar 2009 03:58:56 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679823#action_12679823
] 

Chris Douglas commented on HADOOP-5386:
---------------------------------------

Thanks for addressing all the open issues. All the unit tests pass on fresh checkouts. I'm
still seeing the prenominate failure in one dev environment, but cannot discern its cause.
I doubt that it will be a problem in general.

bq. I changed to use ant copy plus token filter. should be more elegant than sed.
This is a sound improvement. The current strategy of testing for open ports should stop Hudson
from failing.

bq. I explored quite a few time on that. Unfortunately I don't think ant can continue run
build if some part fails. Unless we want to return success even if it fails.
I modified a Chukwa unit test to fail, and it looks like both projects have the same issue.
I filed HADOOP-5434 to address this.

Other than changing the port rolling to advance mod the MAX_AVAILABLE_PORT (so if it happens
to start at or near that point, a single failure to bind won't fail the test), I think the
current patch is fine and could go in as-is.

+1

> To Probe free ports dynamically for Unit test to replace fixed ports
> --------------------------------------------------------------------
>
>                 Key: HADOOP-5386
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5386
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/hdfsproxy
>    Affects Versions: 0.21.0
>            Reporter: zhiyong zhang
>            Assignee: zhiyong zhang
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5386.patch, HADOOP-5386.patch
>
>
> Currently hdfsproxy unit test uses Cactus in-container test. It uses three fixed ports.
one for tomcat start-up/shut-down, another for tomcat http-port and the third for tomcat https-port.

> If theses ports are already in use, ant build will fail. To fix this, we decided to use
a java program to probe the free ports dynamically and update the tomcat conf with these free
ports. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message