Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <1978177584.1235109662755.JavaMail.jira@brutus>
Date: Thu, 19 Feb 2009 22:01:02 -0800 (PST)
From: "Chris Douglas (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-5255) Fix for HADOOP-5079 HashFunction
 inadvertently destroys some randomness
In-Reply-To: <1246767367.1234540621490.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675251#action_12675251 ] 

Chris Douglas commented on HADOOP-5255:
---------------------------------------

+1

> Fix for HADOOP-5079 HashFunction inadvertently destroys some randomness
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-5255
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5255
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 0.20.0, 0.21.0
>            Reporter: stack
>            Priority: Minor
>             Fix For: 0.20.0, 0.21.0
>
>         Attachments: hadoop-core-hash-2-branch-0.20.patch
>
>
> HADOOP-5079 did this "HashFunction.hash restricts initval for the next hash to the [0, maxValue) range of the hash indexes returned. This is suboptimal, particularly for larger nbHash and smaller maxValue. Rather we should first set initval, then restrict the range for the result assignment."  The patch committed on that issue introduced a new bug: "My first patch contained a regression: you have to take the remainder before calling Math.abs, since Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE still" (Jonathan Ellis).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.