Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 46593 invoked from network); 21 Feb 2009 01:32:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 21 Feb 2009 01:32:24 -0000 Received: (qmail 92091 invoked by uid 500); 21 Feb 2009 01:32:23 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 92081 invoked by uid 500); 21 Feb 2009 01:32:23 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 92070 invoked by uid 99); 21 Feb 2009 01:32:23 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Feb 2009 17:32:23 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 21 Feb 2009 01:32:22 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 16E65234C4AB for ; Fri, 20 Feb 2009 17:32:02 -0800 (PST) Message-ID: <1951988552.1235179922092.JavaMail.jira@brutus> Date: Fri, 20 Feb 2009 17:32:02 -0800 (PST) From: "Hadoop QA (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-5291) chukwa agent should do something sensible if CHUKWA_HOME isn't defined In-Reply-To: <437345496.1235081641867.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-5291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675522#action_12675522 ] Hadoop QA commented on HADOOP-5291: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12400550/fixPidFile.patch against trunk revision 746274. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3888/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3888/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3888/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3888/console This message is automatically generated. > chukwa agent should do something sensible if CHUKWA_HOME isn't defined > ---------------------------------------------------------------------- > > Key: HADOOP-5291 > URL: https://issues.apache.org/jira/browse/HADOOP-5291 > Project: Hadoop Core > Issue Type: Bug > Reporter: Ari Rabkin > Assignee: Ari Rabkin > Priority: Trivial > Attachments: fixPidFile.patch > > > If Chukwa is started in such a way that CHUKWA_HOME doesn't get set, then pid files are stored in chukwa/null/var.... This comes up if, e.g., the agent is started within eclipse. We can make this case look prettier by defaulting to /tmp. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.