hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5193) SecondaryNameNode does not rollImage because of incorrect calculation of edits modification time.
Date Sat, 07 Feb 2009 03:06:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671399#action_12671399
] 

Hadoop QA commented on HADOOP-5193:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12399671/EditsLength.patch
  against trunk revision 741762.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3809/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3809/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3809/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3809/console

This message is automatically generated.

> SecondaryNameNode does not rollImage because of incorrect calculation of edits modification
time.
> -------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5193
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5193
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 0.19.1
>
>         Attachments: EditsLength.patch
>
>
> Secondary name-node cannot complete the second phase of the checkpoint because getFsEditsTime()
returns the mod time of {{edits.new}} rather than {{edits}} file.
> The difference is that {{edits}} remains unchanged during the whole checkpoint process
an therefore can serve as an invariant. On the contrary {{edits.new}} is changing all the
time since it is the target of the edits log during checkpoint. So comparison of the mod time
of {{edits.new}} before and after checkpoint fail and name-node does not upload new image
file from the secondary node and does not truncate edits files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message