hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5255) Fix for HADOOP-5079 HashFunction inadvertently destroys some randomness
Date Sun, 15 Feb 2009 09:32:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673580#action_12673580
] 

Hadoop QA commented on HADOOP-5255:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12400190/hadoop-core-hash-2-branch-0.20.patch
  against trunk revision 744406.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3861/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3861/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3861/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3861/console

This message is automatically generated.

> Fix for HADOOP-5079 HashFunction inadvertently destroys some randomness
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-5255
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5255
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 0.20.0, 0.21.0
>            Reporter: stack
>            Priority: Minor
>             Fix For: 0.20.0, 0.21.0
>
>         Attachments: hadoop-core-hash-2-branch-0.20.patch
>
>
> HADOOP-5079 did this "HashFunction.hash restricts initval for the next hash to the [0,
maxValue) range of the hash indexes returned. This is suboptimal, particularly for larger
nbHash and smaller maxValue. Rather we should first set initval, then restrict the range for
the result assignment."  The patch committed on that issue introduced a new bug: "My first
patch contained a regression: you have to take the remainder before calling Math.abs, since
Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE still" (Jonathan Ellis).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message