hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5261) HostsFileReader does not properly implement concurrency support
Date Sun, 15 Feb 2009 17:28:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673684#action_12673684
] 

Hadoop QA commented on HADOOP-5261:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12400223/HADOOP-5261.patch
  against trunk revision 744406.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3865/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3865/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3865/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3865/console

This message is automatically generated.

> HostsFileReader does not properly implement concurrency support
> ---------------------------------------------------------------
>
>                 Key: HADOOP-5261
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5261
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: HADOOP-5261.patch
>
>
> As currently implemented, the class HostsFileReader does not properly allow concurrent
access. 
> It maintains two Sets and manipulates them within synchronized fields, but provides accessor
methods that publish unsynchronized access to the sets' references (getHosts() and getExcludedHosts()).
 The sets are implemented as HashSets, which are not thread safe.  This can allow a method
to obtain a reference to a set that may be modified concurrently by the HostsFileReader.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message