hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5149) HistoryViewer throws IndexOutOfBoundsException when there are files or directories not confrming to log file name convention
Date Sun, 01 Feb 2009 00:45:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669302#action_12669302
] 

Hadoop QA commented on HADOOP-5149:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12399155/HADOOP-5149.trunk.patch
  against trunk revision 739416.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3786/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3786/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3786/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3786/console

This message is automatically generated.

> HistoryViewer throws IndexOutOfBoundsException when there are files or directories not
confrming to log file name convention
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5149
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5149
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.21.0
>            Reporter: Hong Tang
>            Assignee: Hong Tang
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5149.trunk.patch
>
>
> When running history viewer in local mode (specifying file:///<path/to/hodlogs>
as path to logs), it throws IndexOutOfBoundsException due to the following code:
> {code}
>       String[] jobDetails = 
>           JobInfo.decodeJobHistoryFileName(jobFiles[0].getName()).split("_");
>       trackerHostName = jobDetails[0];
>       trackerStartTime = jobDetails[1];
> {code}
> The reason is because there are some directories under the log directories that do not
conform to the log file naming convention, and the length of the jobDetails array is 1.
> History viewer should be more defensive and ignore (possibly with warning) files or directories
that it does not recognize.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message