hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod K V (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5164) Subclasses of ClusterMapReduceTestCase can't easily add new configuration parameters
Date Wed, 04 Feb 2009 12:11:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670313#action_12670313
] 

Vinod K V commented on HADOOP-5164:
-----------------------------------

Even with this patch, we cannot have different cluster properties in different tests of a
single test-case. This, as well as the general problem being pointed, seems to have the only
solution of overriding setUp() to do nothing and calling startCluster explicitly in each test
with any required config properties.

Further, I don't clearly understand why you want to be able to invoke TestCase.setUp(), it
does nothing anyways.

> Subclasses of ClusterMapReduceTestCase can't easily add new configuration parameters
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5164
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5164
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: George Porter
>         Attachments: HADOOP-5164.patch
>
>
> Currently there is not a clean way for subclasses of ClusterMapReduceTestCase to add
to the JobConf used to start the cluster daemons.
> The startCluster() method does take a Properties object that is added to the JobConf
used to the start the daemons.  However, startCluster() is called from JUnit inside the setUp()
method, which sets this parameter to be null.
> If you try to override setUp() in a subclass of ClusterMapReduceTestCase, then you won't
be able to invoke the TestCase.setUp() ancestor without calling ClusterMapReduceTestCase's
setUp() (which will pass in the null parameter).  On the other hand, if you just call startCluster()
within your test method, then you would be starting up a cluster that was already started.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message