hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nigel Daley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5198) NPE in Shell.runCommand()
Date Tue, 17 Feb 2009 05:57:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674102#action_12674102
] 

Nigel Daley commented on HADOOP-5198:
-------------------------------------

Can pid become null between where you check for it and where you call ProcessTree.destroy(...)?

Can you write a unit test?  If not, can you describe the steps of the manual testing you did
to ensure this patch works?

> NPE in Shell.runCommand()
> -------------------------
>
>                 Key: HADOOP-5198
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5198
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred, util
>    Affects Versions: 0.21.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.21.0
>
>         Attachments: patch-5198.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I have seen one of the task failures with following exception:
> java.lang.NullPointerException
> 	at java.lang.ProcessBuilder.start(ProcessBuilder.java:441)
> 	at org.apache.hadoop.util.Shell.runCommand(Shell.java:149)
> 	at org.apache.hadoop.util.Shell.run(Shell.java:134)
> 	at org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:286)
> 	at org.apache.hadoop.util.ProcessTree.isAlive(ProcessTree.java:244)
> 	at org.apache.hadoop.util.ProcessTree.sigKillInCurrentThread(ProcessTree.java:67)
> 	at org.apache.hadoop.util.ProcessTree.sigKill(ProcessTree.java:115)
> 	at org.apache.hadoop.util.ProcessTree.destroyProcessGroup(ProcessTree.java:164)
> 	at org.apache.hadoop.util.ProcessTree.destroy(ProcessTree.java:180)
> 	at org.apache.hadoop.mapred.JvmManager$JvmManagerForType$JvmRunner.kill(JvmManager.java:377)
> 	at org.apache.hadoop.mapred.JvmManager$JvmManagerForType.reapJvm(JvmManager.java:249)
> 	at org.apache.hadoop.mapred.JvmManager$JvmManagerForType.access$000(JvmManager.java:113)
> 	at org.apache.hadoop.mapred.JvmManager.launchJvm(JvmManager.java:76)
> 	at org.apache.hadoop.mapred.TaskRunner.run(TaskRunner.java:411)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message