hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "George Porter (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5164) Subclasses of ClusterMapReduceTestCase can't easily add new configuration parameters
Date Wed, 18 Feb 2009 02:42:01 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674434#action_12674434

George Porter commented on HADOOP-5164:

Thanks for the feedback Vinod.

I went ahead and refactored out all of the startCluster() calls and made each test case explicitly
call them, rather than having an implicit call to startCluster(true, null) in setUp().  This
should both solve my original problem, as well as give the test writer finer-grained control
over the parameters passed to each test cluster.  What do you think?

> Subclasses of ClusterMapReduceTestCase can't easily add new configuration parameters
> ------------------------------------------------------------------------------------
>                 Key: HADOOP-5164
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5164
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: George Porter
>         Attachments: HADOOP-5164.1.patch, HADOOP-5164.patch
> Currently there is not a clean way for subclasses of ClusterMapReduceTestCase to add
to the JobConf used to start the cluster daemons.
> The startCluster() method does take a Properties object that is added to the JobConf
used to the start the daemons.  However, startCluster() is called from JUnit inside the setUp()
method, which sets this parameter to be null.
> If you try to override setUp() in a subclass of ClusterMapReduceTestCase, then you won't
be able to invoke the TestCase.setUp() ancestor without calling ClusterMapReduceTestCase's
setUp() (which will pass in the null parameter).  On the other hand, if you just call startCluster()
within your test method, then you would be starting up a cluster that was already started.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message