hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amareshwari Sriramadasu (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4759) HADOOP-4654 to be fixed for branches >= 0.19
Date Thu, 05 Feb 2009 03:45:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670623#action_12670623
] 

Amareshwari Sriramadasu commented on HADOOP-4759:
-------------------------------------------------

bq. -1 findbugs. The patch appears to introduce 2 new Findbugs warnings.
Warnings:
1.  JvmRunner.runChild(JvmManager$JvmEnv) ignores exceptional return value of java.io.File.delete()
I would like to ignore the return value, it doesn't do anything with the return value.
2. Unread field: org.apache.hadoop.mapred.JvmManager$JvmManagerForType.tracker :This field
is never read.  Consider removing it from the class.
Though tracker reference is not used anywhere in JvmManager, I don't want to delete it from
JvmManager, since it could be used later.

contrib-test failure org.apache.hadoop.chukwa.datacollection.agent.TestAgentConfig.testInitAdaptors_vs_Checkpoint
is not related to the patch.

> HADOOP-4654 to be fixed for branches >= 0.19
> --------------------------------------------
>
>                 Key: HADOOP-4759
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4759
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.19.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.19.1, 0.20.0
>
>         Attachments: patch-4759-0.19.txt, patch-4759-0.20.txt, patch-4759-1-0.19.txt,
patch-4759-1.txt, patch-4759-2.txt, patch-4759-3.1.txt, patch-4759-3.txt, patch-4759.txt
>
>
> Since HADOOP-4654 is fixed only for branch 18.3. This jira looks at the issue reported
for 0.19 and above branches 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message