hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nigel Daley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5232) preparing HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson slaves.
Date Wed, 18 Feb 2009 07:39:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674503#action_12674503
] 

Nigel Daley commented on HADOOP-5232:
-------------------------------------

Thanks Giri.

Comments on hudsonPatchQueueAdmin.sh.patch:
# why is $3 used instead of assigning to a variable name?
# set -x shouldn't be set in this script as it will leak the build token secret (which I think
is $3) to the console
# where is BUILD_SERVERS defined? CALLEDBY?
# why use a directory to store defectNum ($CURRENT_DIR/defectNum)? -- instead just keep defect
numbers in a single file
# please preserve 2 space indents
# removed un-used lines (like #TRIGGER_BUILD_URL=$3)

Comments on test-patch.sh.patch:
# where's the 18th parameter?
# give more info on *why* in this echo: "Calling the Patch Queue Admin"

Can you provide examples of how these scripts are now called?  (don't leak the secret build
token).



> preparing HadoopPatchQueueAdmin.sh,test-patch.sh scripts to run builds on hudson slaves.
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5232
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5232
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: build
>            Reporter: Giridharan Kesavan
>            Assignee: Giridharan Kesavan
>         Attachments: hudsonPatchQueueAdmin.sh.patch, test-patch.sh.patch
>
>
> To modify hadoopPatchQueueAdmin.sh and test-patch.sh script to run patch builds on hudson
slaves.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message