Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 18210 invoked from network); 9 Jan 2009 17:52:26 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 9 Jan 2009 17:52:26 -0000 Received: (qmail 35347 invoked by uid 500); 9 Jan 2009 17:52:22 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 35319 invoked by uid 500); 9 Jan 2009 17:52:22 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 35138 invoked by uid 99); 9 Jan 2009 17:52:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Jan 2009 09:52:21 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Jan 2009 17:52:19 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id B2FC2234C4AC for ; Fri, 9 Jan 2009 09:51:59 -0800 (PST) Message-ID: <1454912042.1231523519732.JavaMail.jira@brutus> Date: Fri, 9 Jan 2009 09:51:59 -0800 (PST) From: "Prasad Chakka (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-4970) Use the full path when move files to .Trash/Current In-Reply-To: <700162872.1230753711712.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662445#action_12662445 ] Prasad Chakka commented on HADOOP-4970: --------------------------------------- I ran 'ant -Djava5.home=/usr/local/jdk1.5.0_07 -Dforrest.home=/home/dhruba/forrest -Dfindbugs.home=/home/dhruba/findbugs test-patch -Dpatch.file=../hadoopcore/hadoop-4970.patch' and the output is below [exec] ====================================================================== [exec] ====================================================================== [exec] Running Eclipse classpath verification. [exec] ====================================================================== [exec] ====================================================================== [exec] [exec] [exec] [exec] [exec] [exec] [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] [exec] [exec] [exec] ====================================================================== [exec] ====================================================================== [exec] Finished build. [exec] ====================================================================== [exec] ====================================================================== > Use the full path when move files to .Trash/Current > --------------------------------------------------- > > Key: HADOOP-4970 > URL: https://issues.apache.org/jira/browse/HADOOP-4970 > Project: Hadoop Core > Issue Type: Improvement > Components: dfs > Affects Versions: 0.19.0 > Reporter: Prasad Chakka > Assignee: Prasad Chakka > Attachments: hadoop-4970.patch > > > When a directory or file is deleted using rm or rmr, the subtree is moved directly to .Trash/Current. If there are two deleted objects with the same name but with different original paths it is not feasible to undelete them without storing additional information regarding the original paths. Instead if the full path of the deleting object is used while moving (replicating the complete path in .Trash/Current) it will be easier to undelete objects to its original paths. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.