hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joydeep Sen Sarma (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5075) Potential infinite loop in updateMinSlots
Date Tue, 20 Jan 2009 20:46:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665554#action_12665554
] 

Joydeep Sen Sarma commented on HADOOP-5075:
-------------------------------------------

on second thoughts - the original ceil and floor logic should always make progress. completely
buy the theory that the flawed mapWeightSum was causing problems.

if that is indeed the case - the break seems unnecessary (and incorrect - right?)

> Potential infinite loop in updateMinSlots
> -----------------------------------------
>
>                 Key: HADOOP-5075
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5075
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/fair-share
>            Reporter: Matei Zaharia
>            Priority: Blocker
>             Fix For: 0.19.1, 0.20.0, 0.21.0
>
>         Attachments: hadoop-5075-v2.patch, hadoop-5075-v3.patch, hadoop-5075.patch
>
>
> We ran into a problem at Facebook where the updateMinSlots loop in the scheduler was
repeating infinitely. This might happen if, due to rounding, we are unable to assign the last
few slots in a pool. This patch adds a break statement to ensure that the loop exists if it
hasn't managed to assign any slots.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message