hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5079) HashFunction inadvertently destroys some randomness
Date Sat, 24 Jan 2009 06:41:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666841#action_12666841
] 

Hadoop QA commented on HADOOP-5079:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12398264/hadoop-core-hash.patch
  against trunk revision 737253.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3756/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3756/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3756/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3756/console

This message is automatically generated.

>  HashFunction inadvertently destroys some randomness
> ----------------------------------------------------
>
>                 Key: HADOOP-5079
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5079
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: util
>            Reporter: Jonathan Ellis
>            Assignee: stack
>             Fix For: 0.20.0
>
>         Attachments: hadoop-core-hash.patch
>
>
> HashFunction.hash restricts initval for the next hash to the [0, maxValue) range of the
hash indexes returned. This is suboptimal, particularly for larger nbHash and smaller maxValue.
 Rather we should first set initval, then restrict the range for the result assignment.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message