hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4955) Make DBOutputFormat us column names from setOutput(...)
Date Tue, 27 Jan 2009 14:52:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667687#action_12667687
] 

Enis Soztutar commented on HADOOP-4955:
---------------------------------------

    [exec] +1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

I will commit this one once the tests finish. 

> Make DBOutputFormat us column names from setOutput(...)
> -------------------------------------------------------
>
>                 Key: HADOOP-4955
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4955
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.19.0
>         Environment: Ubuntu 8.04, Java 6, MySQL 5.0 (most likely not relevant)
>            Reporter: Kevin Peterson
>         Attachments: hadoop-4955.txt, patch.txt
>
>
> In org.apache.hadoop.mapred.lib.db.DBOutputFormat, the supplied names of the columns
are not used for inserting values. The column names supplied to DBOutputFormat.setOutput(JobConf,
String, String...) are used to determine the number of values to insert, but the order is
dictated by the table definition of the underlying database. This affects the correct indices
for DBWritable.write(PreparedStatement).
> I will attach a patch that correctly maps these values.
> I am characterizing this as a bug rather than an improvement because there may be existing
code which implicitly relied on DBOutputFormat ignoring the supplied table names.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message