hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matei Zaharia (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5075) Potential infinite loop in updateMinSlots
Date Wed, 21 Jan 2009 00:41:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665653#action_12665653
] 

Matei Zaharia commented on HADOOP-5075:
---------------------------------------

Yup, the break should be unnecessary now that the infinities and NaN's have been fixed. I
left it in to prevent an infinite loop if some other bug later introduces the same kind of
problem, but I'm not sure which is the best way to go from a software engineering point of
view - prevent the lockup of a critical system component and hope that users will notice any
infinities on the calculations page, or allow the lockup to make sure that any calculation
problems are noticed. Any thoughts on this?

> Potential infinite loop in updateMinSlots
> -----------------------------------------
>
>                 Key: HADOOP-5075
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5075
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/fair-share
>            Reporter: Matei Zaharia
>            Priority: Blocker
>             Fix For: 0.19.1, 0.20.0, 0.21.0
>
>         Attachments: hadoop-5075-v2.patch, hadoop-5075-v3.patch, hadoop-5075.patch
>
>
> We ran into a problem at Facebook where the updateMinSlots loop in the scheduler was
repeating infinitely. This might happen if, due to rounding, we are unable to assign the last
few slots in a pool. This patch adds a break statement to ensure that the loop exists if it
hasn't managed to assign any slots.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message