Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 63053 invoked from network); 8 Dec 2008 22:30:16 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 Dec 2008 22:30:16 -0000 Received: (qmail 53965 invoked by uid 500); 8 Dec 2008 22:30:17 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 53898 invoked by uid 500); 8 Dec 2008 22:30:17 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 53877 invoked by uid 99); 8 Dec 2008 22:30:17 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Dec 2008 14:30:17 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Dec 2008 22:28:55 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 4E0D8234C33F for ; Mon, 8 Dec 2008 14:29:44 -0800 (PST) Message-ID: <1599491181.1228775384318.JavaMail.jira@brutus> Date: Mon, 8 Dec 2008 14:29:44 -0800 (PST) From: "Konstantin Shvachko (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-4795) Lease monitor may get into an infinite loop In-Reply-To: <540985666.1228523144295.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654608#action_12654608 ] Konstantin Shvachko commented on HADOOP-4795: --------------------------------------------- # I would rename Monitor.check() to something like checkLeases(). # {{esle}} statement can be removed. # Wrapping String Collection into {{ArrayList}} can be replaced by collecting paths to be removed in an {{ArrayList}} and then removing them afterwards in a separate loop. This will be much less copying. > Lease monitor may get into an infinite loop > ------------------------------------------- > > Key: HADOOP-4795 > URL: https://issues.apache.org/jira/browse/HADOOP-4795 > Project: Hadoop Core > Issue Type: Bug > Components: dfs > Reporter: Tsz Wo (Nicholas), SZE > Priority: Blocker > Fix For: 0.18.3 > > Attachments: 4795_20081205.patch, 4795_20081208.patch > > > If a lease is not found in the namespace for some reasons (e.g. bugs), lease monitor may get into an infinite loop. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.