Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 8117 invoked from network); 24 Nov 2008 19:00:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 24 Nov 2008 19:00:08 -0000 Received: (qmail 95719 invoked by uid 500); 24 Nov 2008 19:00:15 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 95686 invoked by uid 500); 24 Nov 2008 19:00:15 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 95670 invoked by uid 99); 24 Nov 2008 19:00:15 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Nov 2008 11:00:15 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Nov 2008 18:58:58 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 64D8E234C297 for ; Mon, 24 Nov 2008 10:59:44 -0800 (PST) Message-ID: <639423675.1227553184412.JavaMail.jira@brutus> Date: Mon, 24 Nov 2008 10:59:44 -0800 (PST) From: "stack (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-3422) Ganglia counter metrics are all reported with the metric name "value", so the counter values can not be seen In-Reply-To: <103653028.1211304955568.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650279#action_12650279 ] stack commented on HADOOP-3422: ------------------------------- Thanks for the review Brian. Unless objection, I'll commit to TRUNK in the next day or so. Should I commit to branch-0.19 too? I'd like to but its only a 'major' bug, not critical nor a blocker. > Ganglia counter metrics are all reported with the metric name "value", so the counter values can not be seen > ------------------------------------------------------------------------------------------------------------ > > Key: HADOOP-3422 > URL: https://issues.apache.org/jira/browse/HADOOP-3422 > Project: Hadoop Core > Issue Type: Bug > Components: metrics > Affects Versions: 0.17.2, 0.18.0, 0.18.1, 0.18.2 > Reporter: Jason > Assignee: stack > Fix For: hudson, 0.19.1, 0.20.0 > > Attachments: diff-20080520-1025.txt, ganglia-patch-3422-and-4137.patch, ganglia-patch-3422-and-4137.patch, ganglia-patch-3422-qand-4137-1.patch, ganglia-patch-3422-updated-v2.patch, ganglia-patch-3422-updated.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > The JobInProgress class reports all metrics with the name "value". The FileMetrics class puts all of the tags into the name when reporting the individual values, but the Ganglia Context does not put the tags into the name.. > This patch modifies the context to build names for the counter metrics out of the tag values. This enables the user to see the indivdual counter values with the ganglia web tool, on a per job basis -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.