Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 83176 invoked from network); 12 Nov 2008 11:40:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 12 Nov 2008 11:40:08 -0000 Received: (qmail 7006 invoked by uid 500); 12 Nov 2008 11:40:12 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 6967 invoked by uid 500); 12 Nov 2008 11:40:12 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 6956 invoked by uid 99); 12 Nov 2008 11:40:12 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Nov 2008 03:40:12 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Nov 2008 11:39:00 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 46CD4234C283 for ; Wed, 12 Nov 2008 03:39:44 -0800 (PST) Message-ID: <232050443.1226489984289.JavaMail.jira@brutus> Date: Wed, 12 Nov 2008 03:39:44 -0800 (PST) From: "Steve Loughran (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-4605) should run old version of unit tests to check back-compatibility In-Reply-To: <589886769.1226008786093.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646874#action_12646874 ] Steve Loughran commented on HADOOP-4605: ---------------------------------------- OK, so it's only API stability at the source code level. That's much easier. What you do need to look out for there is refactoring a class and accidentally having the changes propagate into the API tests. That can be prevented through rigorous review or not having those tests in your IDE when you reach for the refactoring button. Some ideas * Identify those tests that are part of the API and move them into the 'stable api' corner of the package tree * Have a base class that they can all extend {{BackwardsCompatibleTestCase}} or similar to identify these should be stable. * Have a policy about it being good to add new tests here, but changing existing tests needs to be looked at carefully Deprecated code could be handled specially: the tests remain but are somehow tagged to a specific version, so it's OK to delete them when their time is up > should run old version of unit tests to check back-compatibility > ---------------------------------------------------------------- > > Key: HADOOP-4605 > URL: https://issues.apache.org/jira/browse/HADOOP-4605 > Project: Hadoop Core > Issue Type: Improvement > Components: test > Reporter: Doug Cutting > > We should test back-compatibility by running unit tests from a prior release. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.