Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 86268 invoked from network); 19 Nov 2008 18:59:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 19 Nov 2008 18:59:37 -0000 Received: (qmail 63393 invoked by uid 500); 19 Nov 2008 18:59:45 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 63008 invoked by uid 500); 19 Nov 2008 18:59:44 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 62997 invoked by uid 99); 19 Nov 2008 18:59:44 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Nov 2008 10:59:44 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Nov 2008 18:58:30 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 53778234C29A for ; Wed, 19 Nov 2008 10:58:45 -0800 (PST) Message-ID: <1983915904.1227121125340.JavaMail.jira@brutus> Date: Wed, 19 Nov 2008 10:58:45 -0800 (PST) From: "Hadoop QA (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-4297) Enable Java assertions when running tests In-Reply-To: <326722737.1222642485207.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649127#action_12649127 ] Hadoop QA commented on HADOOP-4297: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12393978/HADOOP-4297.patch against trunk revision 718544. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3604/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3604/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3604/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3604/console This message is automatically generated. > Enable Java assertions when running tests > ----------------------------------------- > > Key: HADOOP-4297 > URL: https://issues.apache.org/jira/browse/HADOOP-4297 > Project: Hadoop Core > Issue Type: Improvement > Components: build > Affects Versions: 0.19.0, 0.20.0 > Reporter: Yoram Kulbak > Fix For: 0.20.0 > > Attachments: HADOOP-4297.patch, HADOOP-4297.patch > > > A suggestion to enable Java assertions in the project's build xml when running tests. I think this would improve the build quality. > To enable assertions add the following snippets to the JUnit tasks in build.xml: > > > > -- > For example: > > ... > > > > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.