Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 73165 invoked from network); 7 Nov 2008 02:19:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 7 Nov 2008 02:19:41 -0000 Received: (qmail 51054 invoked by uid 500); 7 Nov 2008 02:19:41 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 51013 invoked by uid 500); 7 Nov 2008 02:19:41 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 50998 invoked by uid 99); 7 Nov 2008 02:19:41 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Nov 2008 18:19:41 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Nov 2008 02:18:32 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 4BA3F234C280 for ; Thu, 6 Nov 2008 18:18:44 -0800 (PST) Message-ID: <1875420541.1226024324308.JavaMail.jira@brutus> Date: Thu, 6 Nov 2008 18:18:44 -0800 (PST) From: "Chris Douglas (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Resolved: (HADOOP-4419) JobTracker.setJobPriority() doesn't check for a jobID lookup failing In-Reply-To: <1454621095.1224076424365.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-4419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Douglas resolved HADOOP-4419. ----------------------------------- Resolution: Duplicate This is being fixed in HADOOP-4420 > JobTracker.setJobPriority() doesn't check for a jobID lookup failing > -------------------------------------------------------------------- > > Key: HADOOP-4419 > URL: https://issues.apache.org/jira/browse/HADOOP-4419 > Project: Hadoop Core > Issue Type: Bug > Components: mapred > Affects Versions: 0.19.0, 0.20.0 > Reporter: Steve Loughran > Priority: Minor > > Looking at the entry points of the JobTracker API, it seems that JobTracker.setJobPriority() doesnt expect the JobID lookup ever to return null > It goes straight from lookup to checking access, an operation that assumes that job!=null > JobInProgress job = jobs.get(jobid); > checkAccess(job, QueueManager.QueueOperation.ADMINISTER_JOBS); > Recommend: add a test that calls this operaton with an invalid jobID, then fix the code as appropriate -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.