Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 48835 invoked from network); 20 Nov 2008 01:40:16 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 20 Nov 2008 01:40:16 -0000 Received: (qmail 47393 invoked by uid 500); 20 Nov 2008 01:40:14 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 47268 invoked by uid 500); 20 Nov 2008 01:40:13 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 47248 invoked by uid 99); 20 Nov 2008 01:40:13 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Nov 2008 17:40:13 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Nov 2008 01:38:59 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 7B523234C298 for ; Wed, 19 Nov 2008 17:39:44 -0800 (PST) Message-ID: <1798143117.1227145184504.JavaMail.jira@brutus> Date: Wed, 19 Nov 2008 17:39:44 -0800 (PST) From: "Robert Chansler (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Updated: (HADOOP-4579) StorageDirectory is not removed from the storage directories list when writing to an edits fails In-Reply-To: <1647295779.1225746764185.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Chansler updated HADOOP-4579: ------------------------------------ Fix Version/s: 0.20.0 Status: Patch Available (was: Open) Not suitable for unit testing since this relies on a particular failure mode. > StorageDirectory is not removed from the storage directories list when writing to an edits fails > ------------------------------------------------------------------------------------------------ > > Key: HADOOP-4579 > URL: https://issues.apache.org/jira/browse/HADOOP-4579 > Project: Hadoop Core > Issue Type: Bug > Components: dfs > Reporter: Boris Shkolnik > Assignee: Boris Shkolnik > Fix For: 0.20.0 > > Attachments: hadoop4579.patch > > > If there is an IO Error on any log operations the directory should be removed from the list of active storage directories. > when it happens function FSEditLog:processIOError() is called. > in this function: > .... > File parentStorageDir = ((EditLogFileOutputStream)editStreams.get(index)).getFile().getParentFile().getParentFile(); -- which returns root > .... > fsimage.processIOErrors(parentStorageDir); > ... > which calles FSImage:ProcessIOErrors(dir). > but when dir is compared against list of storage dirs getParent is used instead of getPath() > so the match is never found. > .... > if (sd.getRoot().getPath().equals(dirName.getParent())) { - should be dirName.getPath() > ..... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.