Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 56618 invoked from network); 13 Nov 2008 01:28:11 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 13 Nov 2008 01:28:11 -0000 Received: (qmail 36564 invoked by uid 500); 13 Nov 2008 01:28:12 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 36512 invoked by uid 500); 13 Nov 2008 01:28:12 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 36501 invoked by uid 99); 13 Nov 2008 01:28:12 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Nov 2008 17:28:12 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Nov 2008 01:27:00 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 50854234C282 for ; Wed, 12 Nov 2008 17:27:44 -0800 (PST) Message-ID: <1453383823.1226539664328.JavaMail.jira@brutus> Date: Wed, 12 Nov 2008 17:27:44 -0800 (PST) From: "Chris Douglas (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-4589) Fix the PiEstimator output messages and code comments In-Reply-To: <592634528.1225854944360.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-4589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647151#action_12647151 ] Chris Douglas commented on HADOOP-4589: --------------------------------------- This looks good. Instead of writing files and using SequenceFileInputFormat, it would be better to get the offset and sample count directly from InputSplits. This could be a separate issue > Fix the PiEstimator output messages and code comments > ----------------------------------------------------- > > Key: HADOOP-4589 > URL: https://issues.apache.org/jira/browse/HADOOP-4589 > Project: Hadoop Core > Issue Type: Bug > Components: documentation, examples > Reporter: Tsz Wo (Nicholas), SZE > Assignee: Tsz Wo (Nicholas), SZE > Priority: Minor > Attachments: 4589_20081106.patch, 4589_20081107.patch > > > There are bugs in the PiEstimator output messages and the code comments are insufficient for beginners learning map/reduce programs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.