Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <1279851875.1227404864309.JavaMail.jira@brutus>
Date: Sat, 22 Nov 2008 17:47:44 -0800 (PST)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-3422) Ganglia counter metrics are all
 reported with the metric name "value", so the counter values can not be
 seen
In-Reply-To: <103653028.1211304955568.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649991#action_12649991 ] 

Hadoop QA commented on HADOOP-3422:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12394440/ganglia-patch-3422-updated-v2.patch
  against trunk revision 719787.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3635/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3635/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3635/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3635/console

This message is automatically generated.

> Ganglia counter metrics are all reported with the metric name "value", so the counter values can not be seen
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3422
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3422
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.17.2, 0.18.0, 0.18.1, 0.18.2
>            Reporter: Jason
>            Assignee: stack
>             Fix For: hudson, 0.19.1, 0.20.0
>
>         Attachments: diff-20080520-1025.txt, ganglia-patch-3422-and-4137.patch, ganglia-patch-3422-and-4137.patch, ganglia-patch-3422-qand-4137-1.patch, ganglia-patch-3422-updated-v2.patch, ganglia-patch-3422-updated.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The JobInProgress class reports all metrics with the name "value". The FileMetrics class puts all of the tags into the name when reporting the individual values, but the Ganglia Context does not put the tags into the name..
> This patch modifies the context to build names for the counter metrics out of the tag values. This enables the user to see the indivdual counter values with the ganglia web tool, on a per job basis

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.