hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4377) Race condition creating S3 buffer directory for NativeS3FileSystem
Date Fri, 07 Nov 2008 23:13:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645902#action_12645902
] 

Hadoop QA commented on HADOOP-4377:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12393516/hadoop-s3n-tmpdir.patch
  against trunk revision 712247.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3551/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3551/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3551/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3551/console

This message is automatically generated.

> Race condition creating S3 buffer directory for NativeS3FileSystem
> ------------------------------------------------------------------
>
>                 Key: HADOOP-4377
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4377
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: fs/s3
>    Affects Versions: 0.18.1
>            Reporter: David Phillips
>            Assignee: David Phillips
>         Attachments: hadoop-s3n-tmpdir.patch, hadoop-s3n-tmpdir.patch
>
>
> The buffer directory is checked for existence, then created if it doesn't exist.  But
the create can fail if the another process creates it in between.  We can fix this by checking
for existence again if the create fails.  I've seen "Cannot create S3 buffer directory" occur,
and this race is the most plausible explanation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message