hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nigel Daley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4044) Create symbolic links in HDFS
Date Wed, 19 Nov 2008 22:45:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649196#action_12649196

Nigel Daley commented on HADOOP-4044:

Dhruba, I'm having trouble enumerating all the test cases that are covered by the unit tests.
 Can you write a test plan that outlines the test cases?  More than that, I'm having understanding
the design of this 200Kb patch from the code and the last 2.5 months of comments on this Jira.
 Is there a design document for this?

>From first glance, I don't see test cases for these:
 - deleting a symlink that points to a file
 - deleting a symlink that points to a directory
 - symlink to a symlink
 - any test cases with relative links
 - delete linked to file, but not link, access link
 - delete linked to file, recreate the same file, access link
 - links to other filesystems
 - archives containing links
 - rename a file to an existing symlink
 - rename a symlink to an existing file
 - setTimes and setReplication cases should check the result on both the symlink and linked
to file
 - tests involving lack of permissions to create symlinks
 - tests that try to createSymlinks with filesystems that don't support them
 - ...

I'm also left with a number of questions:

1. Does setReplication, setTimes, chmod, chgrp, chown apply to the symlink or the underlying
file/dir that the symlink point to?
2. Does fsck report symlinks?
3. Does har:// protocol support symlinks in the path leading to har file?  In har file itself?
4. Why doesn't the main method for this patch, FileSystem.createSymlink(), which declares
to throw IOException, no have any @throws clause in the javadoc.
5. Under what conditions does FileSystem.createSymlink() throw IOException?
...and many more.

> Create symbolic links in HDFS
> -----------------------------
>                 Key: HADOOP-4044
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4044
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: dfs
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>             Fix For: 0.20.0
>         Attachments: 4044_20081030spi.java, HADOOP-4044-strawman.patch, symLink1.patch,
symLink1.patch, symLink11.patch, symLink12.patch, symLink13.patch, symLink14.patch, symLink4.patch,
symLink5.patch, symLink6.patch, symLink8.patch, symLink9.patch
> HDFS should support symbolic links. A symbolic link is a special type of file that contains
a reference to another file or directory in the form of an absolute or relative path and that
affects pathname resolution. Programs which read or write to files named by a symbolic link
will behave as if operating directly on the target file. However, archiving utilities can
handle symbolic links specially and manipulate them directly.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message