hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig Macdonald (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3344) libhdfs: always builds 32bit, even when x86_64 Java used
Date Wed, 05 Nov 2008 08:27:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645170#action_12645170

Craig Macdonald commented on HADOOP-3344:

I have tested on Mac OS X 32bit powerpc 10.4. Will test on Linux in due course (10.4 Mac OS
X is now unsupported platform for trunk, as Java 6 is not provided by default).

Some minor comments:

1. Mac OS X does not have error.h, so my compile fails. hdfsJniHelper.c includes error.h,
added by HADOOP-3549. As far as I can see, it is superfluous. At least on Linux, there are
no functions in error.h which hdfsJniHelper.c uses. Should i reopen HADOOP-3549, or file a
new issue? Note that error.h should not be confused with the standard errno.h

2. Will create-c++-configure be called for every compile? It customary to include the generated
configure/Makefile, as people compiling need not have autoconf/automake.

3. (related to 2) Your patch includes configure/Makefile etc, which is great for testing the
patch atm, but the version committed should NOT include these.


> libhdfs: always builds 32bit, even when x86_64 Java used
> --------------------------------------------------------
>                 Key: HADOOP-3344
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3344
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: build, libhdfs
>         Environment: x86_64 linux, x86_64 Java installed
>            Reporter: Craig Macdonald
>            Assignee: Giridharan Kesavan
>         Attachments: HADOOP-3344-v2.patch, HADOOP-3344.v0.patch, HADOOP-3344.v1.patch,
> The makefile for libhdfs is hard-coded to compile 32bit libraries. It should perhaps
compile dependent on which Java is set.
> The relevant lines are:
> LDFLAGS = -L$(JAVA_HOME)/jre/lib/$(OS_ARCH)/server -ljvm -shared -m32 -Wl,-x
> CPPFLAGS = -m32 -I$(JAVA_HOME)/include -I$(JAVA_HOME)/include/$(PLATFORM)
> $OS_ARCH can be (e.g.) amd64 if you're using a 64bit java on the x86_64 platform. So
while gcc will try to link against the correct libjvm.so, it will fail because libhdfs is
to be built 32bit (because of -m32)
> {noformat}
>      [exec] /usr/bin/ld: skipping incompatible /usr/java64/latest/jre/lib/amd64/server/libjvm.so
when searching for -ljvm
>      [exec] /usr/bin/ld: cannot find -ljvm
>      [exec] collect2: ld returned 1 exit status
>      [exec] make: *** [/root/def/hadoop-0.16.3/build/libhdfs/libhdfs.so.1] Error 1
> {noformat}
> The solution should be to specify -m32 or -m64 depending on the os.arch detected.
> There are 3 cases to check:
>  * 32bit OS, 32bit java => libhdfs should be built 32bit, specify -m32
>  * 64bit OS, 32bit java => libhdfs should be built 32bit, specify -m32
>  * 64bit OS, 64bit java => libhdfs should be built 64bit, specify -m64

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message