hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4703) DataNode.createInterDataNodeProtocolProxy should not wait for proxy forever while recovering lease
Date Fri, 21 Nov 2008 19:23:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649769#action_12649769
] 

Tsz Wo (Nicholas), SZE commented on HADOOP-4703:
------------------------------------------------

{noformat}
     [exec] -1 overall.  

     [exec]     +1 @author.  The patch does not contain any @author tags.

     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified
tests.
     [exec]                         Please justify why no tests are needed for this patch.

     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.

     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.

     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.

     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
{noformat}

Running unit tests locally.

> DataNode.createInterDataNodeProtocolProxy should not wait for proxy forever while recovering
lease
> --------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-4703
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4703
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Hairong Kuang
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.18.3
>
>         Attachments: 4073_20081120.patch
>
>
> The problem is that the list of DataNodes may contain DataNode that has already shutdown
as the case in TestFileCreationClient.testClientTriggeredLeaseRecovery(). Using waitForProxy
causes the DataNode to wait forever for the dead DataNode.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message