hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4282) User configurable filter fails to filter accesses to certain directories
Date Mon, 10 Nov 2008 23:11:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646404#action_12646404
] 

Chris Douglas commented on HADOOP-4282:
---------------------------------------

{noformat}
-        handler.addFilterPathMapping(ctx.getContextPath() + "/*", name,
-            Dispatcher.__ALL);
+        defineFilter(ctx, name, classname, parameters, ALL_URLS);
         LOG.info("Added filter " + name + " (class=" + classname
             + ") to context path " + ctx.getContextPath() + "/*");
{noformat}

The log message should probably use Arrays.toString(ALL_URLS) instead of "/*"; otherwise +1

> User configurable filter fails to filter accesses to certain directories
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4282
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4282
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Kan Zhang
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.19.1
>
>         Attachments: 4282_20081103.patch
>
>
> Hadoop-3854 introduced a framework where users can add filters to the HTTP server to
filter part of the HTTP interface, i.e., those user facing URLs. Directories "/logs/*" and
"/static/*" are supposed to be filtered. However, files in those directories can be retrieved
without triggering my configured filter. The corresponding junit test didn't catch the bug
for 2 reasons. 1) it didn't try to access files in those 2 directories. 2) Even if it did,
it might still fail to catch the bug, since according to my observation, only when accessing
existent files my filter is bypassed. When accessing non-existent files (which is what the
junit test does), my filter is triggered as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message