hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4185) Add setVerifyChecksum() method to FileSystem
Date Wed, 12 Nov 2008 17:27:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646963#action_12646963
] 

Doug Cutting commented on HADOOP-4185:
--------------------------------------

> clients cannot tell whether the fs supports checksum

We could have the method return a boolean.

/** @returns true if data verification is enabled. */
public boolean setVerifyData(boolean) { return false; }

But do clients actually care whether the fs supports verification? At this point the FsShell
does not care.  All that it requires is that one can say, "if you support checksums, disable
them", which is what the current patch implements.  If we someday in the future need to support
such inquiries, then we can add support for that then.  But right now, I don't see that that
is needed.

I'm +1 for the patch as-is.


> Add setVerifyChecksum() method to FileSystem
> --------------------------------------------
>
>                 Key: HADOOP-4185
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4185
>             Project: Hadoop Core
>          Issue Type: Sub-task
>          Components: fs
>            Reporter: Tom White
>            Assignee: Sharad Agarwal
>         Attachments: 4185_v1.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message