hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4600) JspHelper should be a singleton
Date Sun, 09 Nov 2008 07:56:46 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646052#action_12646052
] 

Hadoop QA commented on HADOOP-4600:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12393560/4600-0.patch
  against trunk revision 712344.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3562/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3562/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3562/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3562/console

This message is automatically generated.

> JspHelper should be a singleton
> -------------------------------
>
>                 Key: HADOOP-4600
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4600
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Chris Douglas
>            Priority: Minor
>         Attachments: 4600-0.patch
>
>
> Servlets creating JspHelper instances initialize a set of statics and use the empty instance
as a handle to class methods. Instead, JspHelper should either be a singleton with instance
fields or its methods should also be static.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message