hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-4600) JspHelper should be a singleton
Date Tue, 11 Nov 2008 19:37:44 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-4600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Douglas updated HADOOP-4600:
----------------------------------

    Status: Open  (was: Patch Available)

Patch is no longer in sync with trunk. Also, the marginal benefit of making this a singleton
doesn't fix what ails this class.

> JspHelper should be a singleton
> -------------------------------
>
>                 Key: HADOOP-4600
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4600
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Chris Douglas
>            Priority: Minor
>         Attachments: 4600-0.patch
>
>
> Servlets creating JspHelper instances initialize a set of statics and use the empty instance
as a handle to class methods. Instead, JspHelper should either be a singleton with instance
fields or its methods should also be static.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message