hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-693) JobClient can be constructed without initializing object state
Date Tue, 11 Nov 2008 15:50:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646575#action_12646575
] 

Steve Loughran commented on HADOOP-693:
---------------------------------------

{{JobClient}} implements {{Tool}} and hence {{Configurable}}, so {{setConf()}} is a way to
do late-binding configuration. To remove the empty constructor, you'd also need to pull this
method, the few tests that use it, and run a risk of backwards compatibility. It may be better
to have a {{verifyConfigured()}} method on various methods that throws an exception if the
class is used before being configured.

> JobClient can be constructed without initializing object state
> --------------------------------------------------------------
>
>                 Key: HADOOP-693
>                 URL: https://issues.apache.org/jira/browse/HADOOP-693
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.8.0
>            Reporter: Nigel Daley
>            Assignee: Owen O'Malley
>
> The JobClient class has a no-arg constructor that does nothing.  This leaves critical
object state uninitialized.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message