hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-4728) Tests for NameNode -checkpoint option with different configurations
Date Thu, 27 Nov 2008 00:10:46 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-4728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Douglas updated HADOOP-4728:
----------------------------------

    Fix Version/s: 0.20.0
           Status: Open  (was: Patch Available)

Minor:
* Please use 2 spaces instead of tabs
* Commented-out code should be removed
* Can setUpConfig be part of TestCase::setUp?
* Instead of {{assertTrue(false)}}, this can just call {{fail(String)}}. It would be helpful
to record the exception, too (StringUtils::stringifyException). {{assertEquals(a, b)}} instead
of {{assertTrue(a == b)}} is also preferred
* Where iterating with FSImage::DirIterator (testSNNStartup, and checkNameNodeFiles, which
should also be merged), the NameNodeDirType is mutually exclusive. It should probably use
a switch, and define whether it's valid to find types other than {{IMAGE}} and {{EDITS}}
* startSecondaryNamenode and the asserts following it are unnecessary. Excluding the log message,
it's equivalent to create it inline, as the exception is rethrown. At least one and probably
both startNameNode methods are similarly unnecessary.

Tests:
* In testSNNwithoutNN, the test will pass if the secondary namenode fails to start because
of a BindException. Shouldn't the logic in canStartSecondaryNode be moved into its caller,
and the test fail for a BindException? The test has not validated what it claims to
* baseDir should default to /tmp instead of dfs/data
* The test(s) should clean up when finished.

> Tests for NameNode -checkpoint option with different configurations 
> --------------------------------------------------------------------
>
>                 Key: HADOOP-4728
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4728
>             Project: Hadoop Core
>          Issue Type: Test
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: HADOOP-4728.patch
>
>
> here are the tests:
> id               :   secnn-4
> Desc         :   Start SecondaryNameNode first before starting NameNode  	 
> Expected 
> results      :    Secondary namenode should fail to start
> ---------------------------------
> id               :  secnn-6
> Desc         :  Configure NameNode with dfs.name.dir and dfs.name.edits.dir pointing
to different directories. Make sure the directories are empty.
>                      Use default configuration for fs.checkpoint.dir and fs.checkpoint.edits.dir
pointing to same directory.
>                      Start NameNode using -importCheckpoint.
> Expected
> results      : 	Name-node should import image and edits into different directories. 
> ---------------------------------
> id               :  secnn-7  	
> Desc         :  Start NameNode.
>                       Configure SecondaryNameNode with fs.checkpoint.dir and fs.checkpoint.edits.dir
pointing to different directories.
>                       Start SecondaryNameNode. 	
> Expected
> results       :  Secondary name-node should download edits and create the image in different
directories. 
> ----------------------------
> id                :  secnn-8
> Desc          : Configure NameNode with dfs.name.dir and dfs.name.edits.dir pointing
to different directories. Make sure the directories are empty.
>                       Configure fs.checkpoint.dir and fs.checkpoint.edits.dir pointing
to different (same as in secnn-7) directories.
>                       Start NameNode using -importCheckpoint. 	
> Expected
> Results      : Name-node should import image and edits into different directories. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message