hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4583) Code optimization/cleanup in HDFS
Date Sat, 08 Nov 2008 02:10:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645939#action_12645939
] 

Hadoop QA commented on HADOOP-4583:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12393485/4583.patch
  against trunk revision 712305.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3552/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3552/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3552/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3552/console

This message is automatically generated.

> Code optimization/cleanup in HDFS
> ---------------------------------
>
>                 Key: HADOOP-4583
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4583
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: 0.20.0
>
>         Attachments: 4583.patch, 4583.patch
>
>
> Some of the changes needed:
> - FSNameSystem.allocateBlock creates a lot of object unnecessarily to find a blockID
that is unused. It should reuse the Block object created by changing the blockID and reusing
the GenerationStamp.
> - InodeFile.addBlock should use System.arrayCopy instead of copying 1 at a time.
> - Some of the for loops in FSEditLog.java can be optimized. Instead of getting the edit
stream length in termination condition, a local variable should be used to do the same.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message