hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-4559) Rest API for retrieving job / task statistics
Date Sat, 08 Nov 2008 00:50:44 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Douglas updated HADOOP-4559:
----------------------------------

    Status: Open  (was: Patch Available)

bq. although its a JSP page, everything, including printing, is done in Java code. It would
either be better implemented as a pure servlet
+1

* Please format the code according to the [conventions|http://wiki.apache.org/hadoop/HowToContribute#head-59ae13df098fbdcc46abdf980aa8ee76d3ee2e3b].
* There's a fair amount of dead code in this patch, e.g.
{noformat}
+	    StringBuffer sb = new StringBuffer();
+	    boolean isFirst = true;
+	    for (String kv : kv_pairs) {
+	    	
+			sb.append(kv);	
+		}
{noformat}
{{kv_pairs}} is initialized, but empty. {{sb}} is unused, save in this loop. The loop above
it doesn't appear to do any productive work. StringBuilder should be used instead of StringBuffer
in this context.
* If you're proposing this as a public API, it must at least have a unit test.
* Isn't most of this provided through job history?

> Rest API for retrieving job / task statistics 
> ----------------------------------------------
>
>                 Key: HADOOP-4559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4559
>             Project: Hadoop Core
>          Issue Type: New Feature
>            Reporter: Florian Leibert
>            Priority: Trivial
>             Fix For: 0.20.0
>
>         Attachments: HADOOP-4559.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> a rest api that returns a simple JSON containing information about a given job such as:
 min/max/avg times per task, failed tasks, etc. This would be useful in order to allow external
restart or modification of parameters of a run.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message