hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4668) Improve JavaDoc on JobConf.setCombinerClass to better document restrictions on combiners
Date Thu, 20 Nov 2008 19:22:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649451#action_12649451
] 

Tsz Wo (Nicholas), SZE commented on HADOOP-4668:
------------------------------------------------

I suggest to have the following changes:
- "In general typically" => "In general"
- "the the"  => "the"
- "have the same input and output key and value types" => "have the same input/output key
type, and the same input/output value type."  Otherwise, the sentence is hard to be parsed
by beginners.
- should add a </li> for each <li>

> Improve JavaDoc on JobConf.setCombinerClass to better document restrictions on combiners
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-4668
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4668
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>         Attachments: combiner-doc.patch
>
>
> It is often not clear to developers that Combiners may be called 0, 1, or many times
and that combiners input and output types must be the same and the combiner must not have
side effects. Since there isn't a Combiner class, the best place to put this documentation
is on JobConf.setCombinerClass.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message